[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-merge] CONFIG_XEN vs. CONFIG_X86{,_64}_XEN



Lets not forget CONFIG_PPC_XEN :)


On Dec 21, 2005, at 12:19 PM, Jan Beulich wrote:

CONFIG_XEN should be used whenever the change applies
to Xen for all architectures.  CONFIG_X86_XEN should be used
in generic code when a change applies only to x86.
(There was a recent example of this... I can dig it up
if you wish.)

It'd be interesting, if it doesn't take you too much time. I'd have
wanted to rather make this a conditional like

#if defined(CONFIG_XEN) && defined(CONFIG_X86)

as I expect this to be rare.

If the code is clearly x86-specific
(e.g. in arch/i386 or include/asm-x86), I agree the
_X86_ part is superfluous.

Sure. But I'd like this to be consistent, which is why, for now, I used
CONFIG_X86_XEN everywhere.

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge


-JX
--
"I got an idea, an idea so smart my head would explode if I even
began to know what I was talking about." -- Peter Griffin (Family Guy)




_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.