Re: [XenPPC] [PATCH] merge firmware and builtin command lines

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Jun 20, 2006, at 3:32 AM, Amos Waterland wrote:
> The reason for this
> is that Xen hard-codes a value (console=ttyS0) into bootargs, which
> makes Linux in prom_init ignore its own builtin command line and use
> only what Xen provided.
We can get rid of this hardcode with the following (possibly mangled)  
diff:
diff -r 3fa1002443e8 arch/powerpc/platforms/xen/setup.c
--- a/arch/powerpc/platforms/xen/setup.c        Fri Jun 09 09:45:30 2006 -0400
+++ b/arch/powerpc/platforms/xen/setup.c        Tue Jun 20 11:31:18 2006 -0400
@@ -120,6 +120,8 @@ static void __init xen_init_early(void)
                ppc_md.get_boot_time            = mach_maple_md.get_boot_time;
                ppc_md.set_rtc_time             = mach_maple_md.set_rtc_time;
                ppc_md.get_rtc_time             = mach_maple_md.get_rtc_time;
+
+               add_preferred_console("ttyS", 0, NULL);
        }
        DBG("Hello World I'm Maple Xen-LPAR!\n");

We _always_ want ttyS0 with xen and the user can still overrride this  
with a cmdline.
This will remove all "hardcoded" cmdline additions to dom0.
There is prolly a bug or two in boot_of.c around this stuff too.
If there are not objections I'll move forward with this.
-JX

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel