Re: [XenPPC] [xenppc-unstable] [POWERPC] memory cleanup (phase 2), destroy (et. al) now work

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Aug 14, 2006, at 4:57 PM, Hollis Blanchard wrote:

> On Mon, 2006-08-14 at 14:02 +0000, Xen patchbot-xenppc-unstable wrote:
> > @@ -120,7 +121,6 @@ int arch_domain_create(struct domain *d)
> >
> >  void arch_domain_destroy(struct domain *d)
> >  {
> > -    free_domheap_pages(d->arch.rma_page, d->arch.rma_order);
> >      htab_free(d);
> >  }
> >
> > @@ -263,7 +263,7 @@ void sync_vcpu_execstate(struct vcpu *v)
> >
> >  void domain_relinquish_resources(struct domain *d)
> >  {
> > -    /* nothing to do? */
> > +    free_domheap_pages(d->arch.rma_page, d->arch.rma_order);
> >  }
> >
> >  void arch_dump_domain_info(struct domain *d)
> Why do we free the HTAB in arch_domain_destroy(),
Xen heap
> but free the RMA in
> domain_relinquish_resources()?
Domheap

everytime you release !xenheap memory, it checks t->tot_pages and if  
its zero releases a d->recnt. only when the refcnt = 1 (made zero by  
destroy) will destroy get called.
-JX


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel