Re: [XenPPC] xm save: adding couple domctl operations to access htab

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Oct 1, 2006, at 3:33 PM, Jimi Xenidis wrote:

> On Oct 1, 2006, at 1:20 PM, poff wrote:
>
> > > I don't know if I'm off base but have you added appropriate code to
> > > linux? specifically arch/powerpc/platforms/xen/hcall.c ?
> > An existing hypercall, viz #36, do_domctl, provides several  
> > commands to access guest domains.
> > For example, XEN_DOMCTL_getmemlist and XEN_DOMCTL_max_mem. Thought  
> > I would add another to
> > copy the htab, XEN_DOMCTL_gethtab. So I think no modification is  
> > needed to hcall.c
> Sadly, there is:
> Some architectures require that the linux kernel has knowledge of  
> all hcalls, and PPc is one of them
> you will notice in:
>   arch/powerpc/platforms/xen/hcall.c: xenppc_privcmd_domctl()
> there is a huge switch statement for all the domctl OPs.
>
> If your case is not in the switch then you are subject to:
>         default:
> 		printk(KERN_ERR "%s: unknown domctl cmd %d\n", __func__,  
> kern_op.cmd);
>                 return -ENOSYS;
>         }
> and hence your ENOSYS
BTW: This message may not reach your dom0 console, you can either see  
it by running the dmesg command --or-- add "debug" to your dom0  
kernel options.  Adding "sysrq=1" may be may also be a good thing  
since init scripts usually disable sysrq.
-JX




_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel