Re: [XenPPC] XenPPC: redundancy definition of __trap_to_gdb with CRASH_DEBUG

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

Not sure what the redundancy is?
I see 2 prototypes and you have added one.
please explain.
-JX
On Oct 3, 2006, at 12:23 PM, Yi Ge wrote:

> It looks like the compiler's problem: it makes a implicit  
> definition of __trap_to_gdb on the <asm/debugger.h>. This will  
> cause the redundancy definition warning and stop the build process  
> in default compiling setting.
>
>
> diff -r d1f6d0f820d8 xen/include/asm-powerpc/debugger.h
> --- a/xen/include/asm-powerpc/debugger.h	Mon Oct 02 21:43:09 2006  
> -0400
> +++ b/xen/include/asm-powerpc/debugger.h	Tue Oct 03 11:49:57 2006  
> -0400
> @@ -74,6 +74,10 @@ extern void __warn(char *file, int line)
>
> #include <xen/gdbstub.h>
>
> +#ifndef TRAP_TO_GDB
> +extern int __trap_to_gdb(struct cpu_user_regs *regs, unsigned long  
> cookie);
> +#define TRAP_TO_GDB
> +#endif
> static inline int debugger_trap_fatal(
> unsigned int vector, struct cpu_user_regs *regs)
> {
> diff -r d1f6d0f820d8 xen/include/xen/gdbstub.h
> --- a/xen/include/xen/gdbstub.h Mon Oct 02 21:43:09 2006 -0400
> +++ b/xen/include/xen/gdbstub.h Tue Oct 03 11:50:50 2006 -0400
> @@ -56,8 +56,10 @@ void gdb_send_reply(const char *buf, str
> void gdb_send_reply(const char *buf, struct gdb_context *ctx);
>
> /* gdb stub trap handler: entry point */
> +#ifndef TRAP_TO_GDB
> int __trap_to_gdb(struct cpu_user_regs *regs, unsigned long cookie);
> -
> +#define TRAP_TO_GDB
> +#endif
> /* arch specific routines */
> u16 gdb_arch_signal_num(
> struct cpu_user_regs *regs, unsigned long cookie);
>
>
> Best Regards,
> Yi Ge
>
>
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel