Re: [XenPPC] mpic reset

[Michal Ostrowski <mostrows@xxxxxxxxxxxxxx>]

It should not be a problem; I'm fairly certain I've done this at some
point with no ill effects.

If it is a problem, it may be an issue with a specific implementation.

-- 
Michal Ostrowski <mostrows@xxxxxxxxxxxxxx>


On Tue, 2006-10-10 at 19:16 -0400, Amos Waterland wrote:
> I don't see a definitive statement in the mpic spec.  Is it ok to reset
> the mpic an arbitrary number of times, or even more than once, after
> power on?  We are allowing dom0 to reset it at the moment ...
> 
> 
> > diff -r b9e38b262f64 arch/powerpc/sysdev/mpic.c
> > --- a/arch/powerpc/sysdev/mpic.c    Sun Oct 08 14:22:12 2006 -0400
> > +++ b/arch/powerpc/sysdev/mpic.c    Tue Oct 10 18:10:53 2006 -0400
> > @@ -619,6 +619,7 @@ struct mpic * __init mpic_alloc(unsigned
> >     mpic->tmregs = mpic->gregs + ((MPIC_TIMER_BASE - MPIC_GREG_BASE) >> 2);
> >     BUG_ON(mpic->gregs == NULL);
> >  
> > +#if 0
> >     /* Reset */
> >     if (flags & MPIC_WANTS_RESET) {
> >             mpic_write(mpic->gregs, MPIC_GREG_GLOBAL_CONF_0,
> > @@ -628,6 +629,7 @@ struct mpic * __init mpic_alloc(unsigned
> >                    & MPIC_GREG_GCONF_RESET)
> >                     mb();
> >     }
> > +#endif
> 
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel

> 


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel