Re: [XenPPC] [linux-ppc-2.6] [XEN][POWERPC] HYPERVISOR_memory_op() return value now has meaning

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

Yi noticed that we could not build domains with memory beyond the RMA.
This Linux patch fixes that.
-JX
On Nov 14, 2006, at 7:44 PM, Xen patchbot-linux-ppc-2.6 wrote:

> # HG changeset patch
> # User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> # Node ID 47cd37e8f8a91bdf10b314cbaa8d5a9088be30fc
> # Parent  01f3c63f0343051ce1cc039b4bd38def61eb3def
> [XEN][POWERPC] HYPERVISOR_memory_op() return value now has meaning
>
> This patch fixes a "false" failure when calling HYPERVISOR_memory_op()
> from user space, where the return value fromt he hcall is expected.
>
> With this fix, the recent bits can can create domains beyond their  
> RMA.
> Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> ---
>  arch/powerpc/platforms/xen/hcall.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletion(-)
>
> diff -r 01f3c63f0343 -r 47cd37e8f8a9 arch/powerpc/platforms/xen/ 
> hcall.c
> --- a/arch/powerpc/platforms/xen/hcall.c	Sat Nov 11 10:25:31 2006  
> -0500
> +++ b/arch/powerpc/platforms/xen/hcall.c	Tue Nov 14 19:33:36 2006  
> -0500
> @@ -520,7 +520,8 @@ static int xenppc_privcmd_memory_op(priv
>                            sizeof(xen_memory_reservation_t)))
>                 return -EFAULT;
>
> -       if (!HYPERVISOR_memory_op(cmd, &kern_op)) {
> +       ret = HYPERVISOR_memory_op(cmd, &kern_op);
> +       if (ret >= 0) {
>                 if (copy_to_user(user_op, &kern_op,
>                                  sizeof(xen_memory_reservation_t)))
>                         return -EFAULT;
>
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel