[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XenPPC] Continue instead of fail on device_type fetch error



The latest release of SLOF is missing mandatory "device_type" nodes for
both ISA and system-controller (which are both busses).  Until this is
fixed, Xen fails to boot on that release of SLOF.  So work around it by
just printing a warning and continueing.  Thanks to Segher for pointing
out a problem with the first version of this patch.

CC: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>

---

 boot_of.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff -r b30cb72ed5e2 xen/arch/powerpc/boot_of.c
--- a/xen/arch/powerpc/boot_of.c        Fri Nov 03 16:53:17 2006 -0500
+++ b/xen/arch/powerpc/boot_of.c        Tue Nov 21 15:12:33 2006 -0500
@@ -818,8 +818,10 @@ static int __init boot_of_serial(void *o
             of_panic("package-to-path failed\n");
 
         rc = of_getprop(p, "device_type", type, sizeof (type));
-        if (rc == OF_FAILURE)
-            of_panic("fetching device type failed\n");
+        if (rc == OF_FAILURE) {
+            of_printf("%s: fetching type of `%s' failed\n", __func__, buf);
+            continue;
+        }
 
         if (strcmp(type, "serial") != 0)
             continue;

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.