Re: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

On Jan 8, 2007, at 5:46 PM, Yoder Stuart-B08248 wrote:

> This is a minor bug in a debug print that most likely will never
> be seen, as start is typically 0, but it is something I noticed.
thanks, but this patch is incorrect, see below
> Signed-off-by: Stuart Yoder <stuart.yoder@xxxxxxxxxxxxx>
>
>
> diff -r db52c7d043bb xen/arch/powerpc/boot_of.c
> --- a/xen/arch/powerpc/boot_of.c        Tue Dec 19 09:20:58 2006 -0500
> +++ b/xen/arch/powerpc/boot_of.c        Mon Jan 08 16:43:09 2007 -0600
> @@ -419,7 +419,7 @@ static void boot_of_alloc_init(int m, ui
>              start = ALIGN_UP(start, PAGE_SIZE);
start is in bytes here
>              DBG("%s: marking 0x%x - 0x%lx\n", __func__,
> -                pg << PAGE_SHIFT, start);
> +                pg << PAGE_SHIFT, start << PAGE_SHIFT);
becomes "in pages" here
>              start >>= PAGE_SHIFT;
>              while (pg < MEM_AVAILABLE_PAGES && pg < start) {
-JX



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel