Re: [Xen-devel] RE: [Xen-users] Xen in a 32 way system

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 1 Jun 2006, at 18:59, Petersson, Mats wrote:

> Isn't it a bug that we don't check for -EINVAL in the line here:
>         for (i = 0; i < NR_CPUS; i++) {
>                 rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
>                 if (rc == -ENOENT)
>                         break;
>                 cpu_set(i, cpu_possible_map);
>         }
>
> If NR_CPUS in Linux is bigger than 32, then rc = -EINVAL, not -ENOENT
> when it returns from the vcpu_op, because the first check is to see if
> vcpuid is >=32...
>
> Checking if (rc < 0) would be better, I should think...
Yes, the current code is rather mad. I'll fix it.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel