[Xen-users] CONFIG_PCI_MSI and drivers/xen/events.c

[Bartosz Lis <bartoszl@xxxxxxxxxxxxx>]

Hello,

I try to compile pv_ops domU kernel taken from 
http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=shortlog;h=xen/master
and I'm getting:

---cut here--
  CC      drivers/xen/grant-table.o
  CC      drivers/xen/features.o
  CC      drivers/xen/events.o
/root/rpm/BUILD/kernel-
xenUnogrsecurity-2.6.31.5x/linux-2.6.31/drivers/xen/events.c:597: error: 
redefinition of 'xen_destroy_irq'
/root/rpm/BUILD/kernel-
xenUnogrsecurity-2.6.31.5x/linux-2.6.31/arch/x86/include/asm/xen/pci.h:22: 
note: previous definition of 'xen_destroy_irq' was here
/root/rpm/BUILD/kernel-
xenUnogrsecurity-2.6.31.5x/linux-2.6.31/drivers/xen/events.c:666: error: 
redefinition of 'xen_create_msi_irq'
/root/rpm/BUILD/kernel-
xenUnogrsecurity-2.6.31.5x/linux-2.6.31/arch/x86/include/asm/xen/pci.h:16: 
note: previous definition of 'xen_create_msi_irq' was here
make[4]: *** [drivers/xen/events.o] Error 1
make[3]: *** [drivers/xen] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

The problem occured during last few days.

The above error arises when:
XEN_DOM0_PCI - not set
PCI_MSI=y
The last is automticaly selected by AMD_IOMMU.

The error does not arise when XEN_DOM0_PCI=y, what is usually set when one 
compiles dom0 kernel. 

Please tell me, whether it makes sense to leave AMD_IOMMU=y when compiling 
domU kernel. If not, I'll simply switch that symbol off.

When XEN_DOM0_PCI is not set arch/x86/include/asm/xen/pci.h defines 
xen_create_msi_irq and xen_destroy_irq as inlines. Having PCI_MSI or AMD_IOMMU 
set causes drivers/xen/events.c to define these as functions with nontrivial 
body confilicting with the inlines. 

Kind regards,

-- 
Bartosz Lis @ Inst. of Information Technology, Technical Univ. of Lodz, Poland
   bartoszl @ ics.p.lodz.pl

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users