Re: [Xen-users] libxl -> libxenstore dependency

[Philipp Hahn <hahn@xxxxxxxxxxxxx>]

Hello,

Am Mittwoch 10 November 2010 08:10:19 schrieb Josef LiÅka:
> I have done regression testing using git bisect and found following commit:
...
> commit 8b490610757b1c81131c1876a54fd0bfec301c52
...
> diff -Naur a/xenstore/xs.h b/xenstore/xs.h
> --- a/xenstore/xs.h 2010-11-10 00:59:57.000000000 +0100
> +++ b/xenstore/xs.h 2010-11-10 01:02:42.000000000 +0100
> @@ -48,6 +48,9 @@
> /* Close the connection to the xs daemon. */
> void xs_daemon_close(struct xs_handle *);
>
> +/* Throw away the connection to the xs daemon, for use after fork(). */
> +void xs_daemon_destroy_postfork(struct xs_handle *);

Perhaps not directly relevant to your bug, but I found a similar problem with 
our custom-build Debian package for xen-4.0.1:
libxl doesn't link to libxenstore itself, but if you want to use libxl with 
any program, you have to link libxenstore as well, as libxl uses the function 
from libxenstore. This confuses dpkg-shlibdeps, which resolves the 
shared-library-dependencies on a per-symbol basis:
* xs_daemon_destroy_postfork() is only available from >= 4.0.0~rc4.
* libxl uses it, but isn't directly linked to libxenstore, so dpkg-shlibdeps 
isn't able to determin, that libxenstore from >= 4.0.0~rc4 is needed during 
runtime. Instead it just declares a dependency on libxenstore.
* Any program (currently only xl) using libxl might crash during runtime as 
soon as xs_daemon_destroy_postfork() while an old libxenstore is installed.

Something like the following pseudo-patch solved the problem by already 
linking libxl to libxenstore:

@ xen-4.0.1/tools/libxl/Makefile:62
 libxenlight.so.$(MAJOR).$(MINOR): $(LIBXL_OBJS)
-        $(CC) $(CFLAGS) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.
$(MAJOR) $(SHLIB_CFLAGS) -o $@ $^
+        $(CC) $(CFLAGS) $(LDFLAGS) $(LDFLAGS_libxenstore) -Wl,
$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_CFLAGS) -o $@ $^

Alternatively incrementing the minior version of libxenstore would have been a 
good idea, since a new function was added.

Sincerely
Philipp Hahn
-- 
Philipp Hahn           Open Source Software Engineer      hahn@xxxxxxxxxxxxx   
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  28359 Bremen                   fax: +49 421 22 232-99
                                                    http://www.univention.de

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users