Re: Xen compile error

[Bertrand Marquis <Bertrand.Marquis@xxxxxxx>]

Hi

+ xen-users

> On 9 Oct 2020, at 17:59, ba1020@xxxxxxxxxxxxx wrote:
> 
> i'm Hi and signing it...
> 
> 
> 
> i solved it with a patch i found on xen-devel , where i had to change three 
> diff Files coz i forgot how to patch
> 
> and than it compiled 
> 

Thanks for the info.

> 
> 
> the patch
> 
> 
> --- xen-4.13.0/tools/libxl/libxlu_pci.c.orig  2019-12-17 14:23:09.000000000 
> +0000
>       
> +++ xen-4.13.0/tools/libxl/libxlu_pci.c       2020-01-21 21:56:26.812212916 
> +0000
>       
> @@ -48,7 +48,7 @@
>       
> int xlu_pci_parse_bdf(XLU_Config *cfg, libxl_device_pci *pcidev, const char 
> *str)
>       
> {
>       
>     unsigned state = STATE_DOMAIN;
>       
> -    unsigned dom, bus, dev, func, vslot = 0;
>       
> +    unsigned dom = 0, bus = 0, dev = 0, func = 0, vslot = 0;
>       
>     char *buf2, *tok, *ptr, *end, *optkey = NULL;
>       
> 
> 
>       
>     if ( NULL == (buf2 = ptr = strdup(str)) )
>       
> --- xen-4.13.0/tools/libxl/libxl_utils.c.orig 2019-12-17 14:23:09.000000000 
> +0000
>       
> +++ xen-4.13.0/tools/libxl/libxl_utils.c      2020-01-21 22:34:52.096300774 
> +0000
>       
> @@ -1259,7 +1259,7 @@
>       
>     }
>       
>     memset(un, 0, sizeof(struct sockaddr_un));
>       
>     un->sun_family = AF_UNIX;
>       
> -    strncpy(un->sun_path, path, sizeof(un->sun_path));
>       
> +    strncpy(un->sun_path, path, sizeof(un->sun_path)-1);
>       
>     return 0;
>       
> }
>       
> 
> 
>       
> 
> 
>       
> --- xen-4.13.0/tools/xenpmd/Makefile.orig     2019-12-17 14:23:09.000000000 
> +0000
>       
> +++ xen-4.13.0/tools/xenpmd/Makefile  2020-01-22 22:13:16.564873608 +0000
>       
> @@ -3,6 +3,7 @@
>       
> 
> 
>       
> CFLAGS += -Werror
>       
> CFLAGS += $(CFLAGS_libxenstore)
>       
> +CFLAGS += -Wno-error=format-truncation
>       
> 
> 
>       
> LDLIBS += $(LDLIBS_libxenstore)
>       
> 
> 
> 
> well its not a nice Trap that every Debian user will fall into ...

Can you tell what version of debian you are using ?

Regards
Bertrand

> 
> 
> Signed
> 
> Juergen Schinker
> 
> 
> 
> Sent with ProtonMail Secure Email.
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Friday, October 9, 2020 5:50 PM, Bertrand Marquis 
> <Bertrand.Marquis@xxxxxxx> wrote:
> 
>> Hi,
>> 
> 
>>> On 8 Oct 2020, at 13:28, ba1020@xxxxxxxxxxxxx wrote:
>>> i try to compile the lates Release 4.14.0 and get stuck here
>> 
> 
>> It would be nice to start a mail saying Hi and signing it :-)
>> 
> 
>> You are probably using a new compiler version (10.0 or newer).
>> 
> 
>> You have 2 solutions:
>> 
> 
>> -   you a master version of Xen
>> -   fix libxlu_pci.c at line 51 like this:
>>    unsigned dom = 0, bus = 0, dev = 0, func = 0, vslot =0;
>> 
> 
>>    Please confirm me if this works.
>> 
> 
>>    Cheers
>>    Bertrand
>> 
> 
>> 
> 
>>> libxlu_pci.c: In function ‘xlu_pci_parse_bdf’:
>>> libxlu_pci.c:32:18: error: ‘func’ may be used uninitialized in this 
>>> function [-Werror=maybe-uninitialized]
>>> 32 | pcidev->func = func;
>>> | ~~~~~~~^~
>>> libxlu_pci.c:51:29: note: ‘func’ was declared here
>>> 51 | unsigned dom, bus, dev, func, vslot = 0;
>>> | ^~libxlu_pci.c:31:17: error: ‘dev’ may be used uninitialized in this 
>>> function [-Werror=maybe-uninitialized]
>>> 31 | pcidev->dev = dev;
>>> | ~~~~~~^
>>> libxlu_pci.c:51:24: note: ‘dev’ was declared here
>>> 51 | unsigned dom, bus, dev, func, vslot = 0;
>>> | ^libxlu_pci.c:30:17: error: ‘bus’ may be used uninitialized in this 
>>> function [-Werror=maybe-uninitialized]
>>> 30 | pcidev->bus = bus;
>>> | ~~~~~~^
>>> libxlu_pci.c:51:19: note: ‘bus’ was declared here
>>> 51 | unsigned dom, bus, dev, func, vslot = 0;
>>> | ^libxlu_pci.c:29:20: error: ‘dom’ may be used uninitialized in this 
>>> function [-Werror=maybe-uninitialized]
>>> 29 | pcidev->domain = domain;
>>> | ~~~~~~~^~
>>> libxlu_pci.c:51:14: note: ‘dom’ was declared here
>>> 51 | unsigned dom, bus, dev, func, vslot = 0;
>>> | ^cc1: all warnings being treated as errors
>>> make[5]: *** [/home/adminjs/xen/tools/libxl/../../tools/Rules.mk:216: 
>>> libxlu_pci.o] Error 1
>>> make[5]: *** Waiting for unfinished jobs....
>>> make[5]: Leaving directory '/home/adminjs/xen/tools/libxl'
>>> make[4]: *** [/home/adminjs/xen/tools/../tools/Rules.mk:240: 
>>> subdir-install-libxl] Error 2
>>> make[4]: Leaving directory '/home/adminjs/xen/tools'
>>> make[3]: *** [/home/adminjs/xen/tools/../tools/Rules.mk:235: 
>>> subdirs-install] Error 2
>>> make[3]: Leaving directory '/home/adminjs/xen/tools'
>>> make[2]: *** [Makefile:72: install] Error 2
>>> make[2]: Leaving directory '/home/adminjs/xen/tools'
>>> make[1]: *** [Makefile:134: install-tools] Error 2
>>> make[1]: Leaving directory '/home/adminjs/xen'
>>> make: *** [Makefile:170: world] Error 2
>>> Sent with ProtonMail Secure Email.
>>> <publickey - ba1020@xxxxxxxxxxxxx - 0x949AA924.asc>
> 
> <publickey - ba1020@xxxxxxxxxxxxx - 0x949AA924.asc>