Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM

["George S. Coker, II" <george.coker@xxxxxxxxx>]

> > >      chn->state          = ECS_VIRQ;
> > >      chn->notify_vcpu_id = vcpu;
> > >      chn->u.virq         = virq;
> > > @@ -261,14 +278,15 @@ static long evtchn_bind_ipi(evtchn_bind_
> > >          ERROR_EXIT(port);
> > >
> > >      chn = evtchn_from_port(d, port);
> > > +
> > >      chn->state          = ECS_IPI;
> > >      chn->notify_vcpu_id = vcpu;
> > >
> > >      bind->port = port;
> > >
> > > +    spin_unlock(&d->evtchn_lock);
> > > +
> > >   out:
> > > -    spin_unlock(&d->evtchn_lock);
> > > -
> >
> > This is incorrect, leaves domain locked on error path (yes, ERROR_EXIT
> > is mean macro abuse!).
> >
> Absolutely this is a problem, when did ERROR_EXIT come about?
The patch was generated incorrectly and contains some old edits.  I
don't even mean to be touching this code region.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel