[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH] Intel(R) Trusted Execution Technology support
On Monday, October 29, 2007 10:17 AM, Keir Fraser wrote: > On 29/10/07 15:38, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote: > >>>> Attached is a patch that adds Intel(R) Trusted Execution Technology >>>> (Intel(R) TXT) support to Xen. Intel(R) TXT was formerly known by the >>>> codename LaGrande Technology (LT). >>> >>> Seems to be missing asm-x86/tboot.h. >> >> The build for tboot/tboot copies this file from tboot/include to >> xen/include/asm-x86. Do you prefer that it get checked in to Xen's repo >> instead? > > Okay, another issue. You can't probe for tboot by mapping and reading every > E820_RESERVED region (which is what the code you add to x86/setup.c does). > You don't know what mmio regions you could be conflicting with by making a > cacheable mapping and issuing memory reads (which can have side effects when > issued to I/O devices). > > Why is the memory region not marked as E820_UNUSABLE by tboot? And/or extend > the multiboot info structure and transmit the address of the shared page > that way. I didn't mark it as UNUSABLE because dom0 doesn't like low memory that it can't probe and I didn't realize that there would be a problem with marking it RESERVED. However, I can mark it as UNUSABLE and then when I find it, change it to RESERVED. I'll send a patch for this as well. > > -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |