[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Embedded-pv-devel] [PATCH v9] xen: add para-virtual sound interface header files



>>> On 24.11.16 at 13:53, <andr2000@xxxxxxxxx> wrote:
>>  Any people who wants to use the PV driver for other OS than Linux will have
>> to do it. So, may I ask why don't you write a platform agnostic header?
>>
>> This would also make easier to share the PV driver code between different
>> OS.
> There are 2 files: sndif.h which is platform agnostic and sndif_linux.h
> which is Linux platform specific (this is exactly the file which every 
> platform
> will need to define, e.g. sndif_windows.h).

But that is the very problem: There shouldn't be an assumption that
both side of the communication sit on the same OS, i.e. you need
one fully spelled out header, and that header ...

> In my case I need it to at least define Linux specific __packed
> attribute which is not supported by Win AFAIK.

... needs to avoid using platform specific constructs (or making
other assumptions on the platform). I can only re-iterate: Please
follow the model other PV protocols already present (without
repeating their mistakes, if at all possible).

Jan


_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.