Re: [Embedded-pv-devel] [PATCH v9] xen: add para-virtual sound interface header files

[Oleksandr Andrushchenko <andr2000@xxxxxxxxx>]

> I don't consider sndif.h been agnostic. It is just a bunch of array
> definition.
>
I am not sure I'm following you here.
sndif.h doesn't have any platform specific definitions, but sndif_linux.h does.
Both don't define any methods, but only structures (and __packed as of now).
>Each OS would have to implement their own headers in order to
> easily access command fields.
This is what I did for Linux, the result is sndif_linux.h
> All the other PV protocols are able to define structure that are platform
> agnostic. I would like to understand why you cannot do this here.
>
> Not mentioning that using __packed is usually a bad idea because it can
> mess-up with the natural alignment of the fields and makes the programmer's
> life more miserable (see an example in drm PV drivers).
I need some more time for that

_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel