[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: deviations tagging
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Jun 2022 10:20:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rV7iJ37Br4R9p/ySg6FLbeCdRQKPrM6CKwt/39SqT0=; b=n6rMGpDWIMz30lfr31w3GIEF1OrnMcUSZFF1gkDFLhe6GX9dtl78XHQ3F4RzizGq7tOM4qGG8BSGpNUh5gQBkC9/M0Sdgraqu0BoG5EQrWpOKLNS9Saebso7/AtQx5N/0AiB2JGD9DUluDcJomV8VFBK0qWbgj/2BDGHJ41YslZsfiWU/VgT5GE239Nrqh/gpEwSQ5tkqI3DzHJfUnHrQfAiaR6Fsaaz+iEbObB5vtx5GTZ+X///qjUg72aZ0twkM8Nh79w85FZQqUHhpxYjZeEV2TP6RlP2dkBJUNQL3C4wN8ZzT1zJT4fjG+cTnHVHnKhj8Fx75pYajpwttZnFJg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEuT02TVntXEm9KHkdc6kGPzFx723AEELC2Gxuth9DEIEQkjCLRzIFSx9PFa6FLGSUF12SkVUPLTNN8ATf5c9hgunJ/KD3BAVY5RLADTJcc5ejyxkiD9U9KFMHIsBFfQC/jSfNM0jcDCCLgs5q48HtdMQV8OzC8uB92B5w/rZCvoUKR0j80UqAt/jI2l7GE6lPv6bli1w7Rob2l0uNxvdiNI8r6CdyGlKofshe+l0HL/AZQXSj+hMTOHi8n+/q+MxCRClfs1dbxnVKrzlA5k8FXuarTJwN9GKTVzj6lKC/JUBPvPMStWcAPMVP2HKbSOEwJ/o91mBZsqukuk0gNT6w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Stefano Stabellini <stefanos@xxxxxxxxxx>, "roberto.bagnara@xxxxxxxxxxx" <roberto.bagnara@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "Artem_Mygaiev@xxxxxxxx" <Artem_Mygaiev@xxxxxxxx>, "fusa-sig@xxxxxxxxxxxxxxxxxxxx" <fusa-sig@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Jun 2022 19:24:33 +0000
- List-id: This is a discussion list for members of the Xen Project FuSa SIG <fusa-sig.lists.xenproject.org>
On 16.06.2022 02:24, Stefano Stabellini wrote:
> On Wed, 15 Jun 2022, Jan Beulich wrote:
>> On 15.06.2022 10:37, Luca Fancellu wrote:
>>> As first thought I was thinking to propose the above tags with an
>>> incremental number
>>> that could work as a link to a file containing the justification for each
>>> finding.
>>>
>>> /* Safe-<number> */
>>>
>>> So that a preprocessor script can be used later to substitute the tag with
>>> the appropriate
>>> in-code comment suppression tag for a specified checker tool.
>>
>> While (assuming the file holding the justifications is meant to live in
>> xen.git) conflicts on that file would guarantee uniqueness of the number,
>> such conflicts would likely be frequent and require manual resolution
>> every single time. Such conflicts could appear as late as when a patch is
>> being committed, making the committers' (supposedly entirely mechanical)
>> job harder (besides perhaps requiring quite a bit more re-basing effort
>> by the submitter).
>
> To help with that, we could maybe have 1 file per justification
> (matching by filename), rather than 1 global file. E.g.:
>
> /* safe-1122 */
>
> docs/misra/justifications/safe-1122.md
I don't see how this would eliminate conflicts: In a single file the
conflict would (typically) be two patches wanting to add the same number
(with different text). With your new proposal the conflict would be two
parties wanting to add the same new file with different content.
I'm also afraid file-system-wise this wouldn't scale very well. A single
directory with thousands of files isn't very manageable. Plus with the
use of numbers name completion also won't be of much help.
Jan
|
