Re: [Minios-devel] [PATCH v2 21/47] mini-os: implement the memmove/memchr

[Huang Shijie <shijie.huang@xxxxxxx>]

On Thu, Mar 15, 2018 at 09:51:38AM +0100, Juergen Gross wrote:
> On 15/03/18 05:52, Huang Shijie wrote:
> > This patch is split from the Chen Baozi's old patch:
> > 
> > "This activates the ARM code added in the previous patches. On
> >  ARM, Mini-OS will boot and display some output on the console. Tested 
> > with:"
> > 
> > Note: The code is copied from FreeBSD code:
> >       freebsd/contrib/ldns/compat/memmove.c
> > 
> > Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> > ---
> >  Makefile      |  1 +
> >  lib/memmove.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  lib/string.c  | 12 ++++++++++++
> >  3 files changed, 57 insertions(+)
> >  create mode 100644 lib/memmove.c
> > 
> > diff --git a/Makefile b/Makefile
> > index 88315c4..43075e1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -61,6 +61,7 @@ src-y += lib/math.c
> >  src-y += lib/printf.c
> >  src-y += lib/stack_chk_fail.c
> >  src-y += lib/string.c
> > +src-y += lib/memmove.c
> >  src-y += lib/sys.c
> >  src-y += lib/xmalloc.c
> >  src-$(CONFIG_XENBUS) += lib/xs.c
> > diff --git a/lib/memmove.c b/lib/memmove.c
> > new file mode 100644
> > index 0000000..28f2706
> > --- /dev/null
> > +++ b/lib/memmove.c
> > @@ -0,0 +1,44 @@
> > +/*
> > + *     memmove.c: memmove compat implementation.
> > + *
> > + *     Copyright (c) 2001-2008, NLnet Labs. All rights reserved.
> > + *
> > + * See COPYING for the license.
> 
> I think you should add the correct license info and the info from where
> you took the source here.
Ok, I will check and copy the license to here.

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel