Re: [Minios-devel] [PATCH v2 2/2] Save/Restore Support: Add fini_shutdown call to app exit flow.

[Bruno Alvisio <bruno.alvisio@xxxxxxxxx>]

On Tue, Mar 27, 2018 at 4:53 AM, Juergen Gross <jgross@xxxxxxxx> wrote:

On 23/03/18 18:47, Bruno Alvisio wrote:
> Signed-off-by: Bruno Alvisio <bruno.alvisio@xxxxxxxxx>
> ---
> Changed since v1:
> - Decided to leave original exit flow in main.c and add the call to fini_shutdown
> there.
> - Removed kernel_shutdown function entirely.

Removing a function completely should be worth a sentence in the
commit log. Did you test whether all stubdoms still build with this
removal? I think they do, but it would be nice to know you really
verified that.

 

I have sent a new version with a more detailed commit log.

I have verified that stubdoms build with this version.

Thanks!

Other then that I'm fine with the patch.


Juergen

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel