Re: [Minios-devel] [UNIKRAFT PATCH 1/9] build: Adjust sed script to avoid treating arm64 as arm

[Wei Chen <Wei.Chen@xxxxxxx>]

Hi Florian,

Thanks for your comments. Sorry for replying later. I don't know
why this email had been blocked by mail server for several days.

> -----Original Message-----
> From: Minios-devel <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Florian Schmidt
> Sent: 2018年3月15日 17:41
> To: minios-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Minios-devel] [UNIKRAFT PATCH 1/9] build: Adjust sed script to
> avoid treating arm64 as arm
>
> [This sender failed our fraud detection checks and may not be who they appear
> to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing]
>
> Hi,
>
> thanks for the patch series. Simon can probably say more about the
> layout redesign, but browsing over your patch, I found this:
>
> On 03/15/2018 04:39 AM, Wei Chen wrote:
> > -                    -e 's/arm.*/arm/' \
> > +                    -e 's/arm[^6^4].*/arm/' \
>
> [and two more times below that]
>
> I don't think this does the right thing. This matches any line that
> starts with arm, then does not have a single next character that is
> either a 4, a 6, or a ^, and then whatever comes after. So this line
> converts "arm3XYZ" to "arm", but not "arm4XYZ" or "arm^XYZ".
>
> Instead you probably want to match anything that says "arm", followed by
> something, except if it contains the string arm64?
>
> I think this should work instead:
>
> -e '/arm64/! s/arm.*/arm/'
>
> so, only apply the original line if it doesn't contain arm64.
>

Yes, that's what I wanted. I will rebase the whole series to the latest
staging tree. I will apply above change to v2 patch.

Thank you very much!

> Cheers,
> Florian
>
> --
> Dr. Florian Schmidt
> フローリアン・シュミット
> Research Scientist,
> Systems and Machine Learning Group
> NEC Laboratories Europe
> Kurfürsten-Anlage 36, D-69115 Heidelberg
> Tel.     +49 (0)6221 4342-265
> Fax:     +49 (0)6221 4342-155
> e-mail:  florian.schmidt@xxxxxxxxx
> ============================================================
> Registered at Amtsgericht Mannheim, Germany, HRB728558
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel