Re: [Minios-devel] [UNIKRAFT PATCH v2 6/6] plat/xen: Add grant table support for Xen (x86_64)

[Julien Grall <julien.grall@xxxxxxx>]

On 28/06/18 16:18, Costin Lupu wrote:
> Hi Julien,
>
> On 06/28/2018 05:55 PM, Julien Grall wrote:
> > Hi Costin,
> >
> > On 28/06/18 13:38, Costin Lupu wrote:
> > > diff --git a/plat/xen/x86/gnttab.c b/plat/xen/x86/gnttab.c
> > > new file mode 100644
> > > index 0000000..add3444
> > > --- /dev/null
> > > +++ b/plat/xen/x86/gnttab.c
> > All the code below does not look x86 specific. Would not it be better to
> > keep that in common xen code?
> Thanks for the heads-up! For now we chose to keep the arch split like
> it's been in Mini-OS as a safe measure until we have the whole image of
> how the design around gnttab should like after we'll have x86 HVM and
> ARM support. If you'll need to move it for the ARM changes, you have my
> support.
I am not sure why Mini-OS has made this choice... This has nothing to do 
with the architecture, it is more on the "guest type" (auto-translated 
vs none).
The way to initialize grant-table on Arm is the same as x86 HVM. The 
only difference with PV is you would need to map the grant-table frame 
in your guest using XENMEM_add_to_physmap first.
> > Also, just to confirm, you are only focusing on PV support? PVH/HVM will
> > likely require more work (such as calling XENMEM_add_to_physmap with
> > XENMAPSPACE_grant_table during setup).
> Right. In the near future we're covering the basic functionalities only
> of PV support.
It is probably worth to mention it in your cover letter and commit 
message. So you will avoid more people asking why HVM/PVH support is 
left out :).
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel