Re: [Minios-devel] [UNIKRAFT-PATCH 2/3] plat/xen/common: Move event channel functions in events.h

[Julien Grall <julien.grall@xxxxxxx>]

On 18/10/2018 16:44, Radu Nicolau wrote:
> Hello Julien,
>
> On Thu, Oct 18, 2018 at 4:33 PM Julien Grall <julien.grall@xxxxxxx 
> <mailto:julien.grall@xxxxxxx>> wrote:
>     Hello Nicolas,
>
>     On 18/10/2018 12:40, radunicolau102@xxxxxxxxx
>     <mailto:radunicolau102@xxxxxxxxx> wrote:
>      > diff --git a/plat/xen/include/common/events.h
>     b/plat/xen/include/common/events.h
>      > index 971dff9..accddb8 100644
>      > --- a/plat/xen/include/common/events.h
>      > +++ b/plat/xen/include/common/events.h
>      > @@ -47,6 +47,12 @@
>      >   #include <xen/event_channel.h>
>      >   #include <uk/arch/lcpu.h>
>      >
>      > +/*
>      > + * TODO revisit: why cpu param?
>      > + * Taken from linux/drivers/xen/events/events_2l.c
>
>     Are you sure about this? In any case, I would be careful about
>     mentioning Linux code in Unikraft as the two license (GPLv2 vs BSD) are
>     not compatible.
>
>
> I've found this macro (as a function) in the linux kernel and I thought it
> would be helpful to know it was inspired from there. The cpu parameter
> is used in there.
> The macro itself does appear in Mini-OS (both from xenbits and sysml),
> I assume it was ported from there.
> I am not entirely sure how I should proceed in here, I could remove my
> comment or remove the unused parameter entirely.
Either way should be fine.

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel