Re: [Minios-devel] [UNIKRAFT PATCH] plat/kvm: Make VIRTIO_NET depend on VIRTIO_BUS

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello,

Thank you for the patch. The patch looks good.

It was bug in the previous patch while renaming from virtio to virtio_bus.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 11/24/2018 02:08 PM, Teodora Serbanescu wrote:
> This is the setup to reproduce the bug:
> Library Configuration -> enable uknetdev
> Platform Configuration -> enable KVM guest:
>         -> disable Virtio bus driver
>         -> Virtio -> enable Virtio Net device
>
> With this  setup, the following error occurs on build:
> "undefined reference to ` _virtio_bus_register_driver'"
>
> This fix solves the issue by enabling Virtio bus driver every time
> Virtio Net device is enabled.
>
> Signed-off-by: Teodora Serbanescu <teo.serbanescu16@xxxxxxxxx>
> Signed-off-by: Andrei Gogonea <andrei.gogonea09@xxxxxxxxx>
> ---
>   plat/kvm/Config.uk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index fb3677a..4a20a10 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -75,7 +75,7 @@ config VIRTIO_NET
>          bool "Virtio Net device"
>          default n
>          depends on LIBUKNETDEV
> -       select VIRTIO
> +       select VIRTIO_BUS
>          select LIBUKSGLIST
>          help
>                 Virtual network driver.

Thanks & Regards
S Sharan

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel