Re: [Minios-devel] [UNIKRAFT PATCH] plat/xen/xenbus: Add _GNU_SOURCE define when using asprintf

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Thanks for the fix!

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 11/24/18 3:05 PM, Bogdan Lascu wrote:
> Compiling xenbus.c and xs.c gives the warning "implicit definition
> of asprintf". Asprintf is not C nor POSIX, so its declaration is
> conditioned by a header define that is activated by defining _GNU_SOURCE
> before including stdio.h.
> 
> Signed-off-by: Bogdan Lascu <lascu.bogdan96@xxxxxxxxx>
> Signed-off-by: Mihai Pogonaru <pogonarumihai@xxxxxxxxx>
> ---
>  plat/xen/xenbus/xenbus.c | 1 +
>  plat/xen/xenbus/xs.c     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/plat/xen/xenbus/xenbus.c b/plat/xen/xenbus/xenbus.c
> index f693f80..a2cd65c 100644
> --- a/plat/xen/xenbus/xenbus.c
> +++ b/plat/xen/xenbus/xenbus.c
> @@ -32,6 +32,7 @@
>   * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>   */
>  
> +#define _GNU_SOURCE
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <inttypes.h>
> diff --git a/plat/xen/xenbus/xs.c b/plat/xen/xenbus/xs.c
> index f81e9a6..d4819ea 100644
> --- a/plat/xen/xenbus/xs.c
> +++ b/plat/xen/xenbus/xs.c
> @@ -39,6 +39,7 @@
>   * Ported from Mini-OS xenbus.c
>   */
>  
> +#define _GNU_SOURCE
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <string.h>
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel