Re: [Minios-devel] [PATCH 0/2] lib/vfscore: Added stdin

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

thanks for the series. A general comment, the commit message (and the
cover letter) should be in present simple (this is stated int the
CONTRIBUTING.md) and in imperative (e.g. Add the standard input). Like
you did in the second patch.

- Yuri.

"Vlad-Andrei BĂDOIU (78692)" <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
writes:

> Added the standard input fop in stdin.c and
> initialised the stdin on fd 0. Added the 
> __unused macro for both stdin_read and
> stdout_write.
>
> Added the blocking behaviour to the stdin_read
> because ukplat_cink return 0 if nothing is
> being inputted. The python shell uses a fgets
> on stdin and if 0 is return the fgets returns as 
> well which results in the shell terminating.
>
> Added the echo behaviour under the form
> of a stdout_write whenever an input is
> being recieved.
>
> Vlad-Andrei Badoiu (2):
>   lib/vfscore: Implemented stdin fop
>   lib/vfscore: Add both the block and echo support
>
>  lib/vfscore/stdio.c | 34 +++++++++++++++++++++++++++++++---
>  1 file changed, 31 insertions(+), 3 deletions(-)
>
> -- 
> 2.19.1
>

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel