Re: [Minios-devel] [UNIKRAFT PATCH v3 4/4] plat/xen/hypervisor.c: Remove unused parameter

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 11/24/18 1:23 PM, radunicolau102@xxxxxxxxx wrote:
> From: Radu Nicolau <radunicolau102@xxxxxxxxx>
> 
> Removed unused parameter cpu from macro active_evtchns
> 
> Signed-off-by: Radu Nicolau <radunicolau102@xxxxxxxxx>
> ---
>  plat/xen/hypervisor.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/plat/xen/hypervisor.c b/plat/xen/hypervisor.c
> index 8f8048a..c797dc6 100644
> --- a/plat/xen/hypervisor.c
> +++ b/plat/xen/hypervisor.c
> @@ -42,8 +42,7 @@
>  #include <uk/arch/lcpu.h>
>  #include <uk/arch/atomic.h>
>  
> -// TODO revisit: move to evtchn; why cpu param?
> -#define active_evtchns(cpu, sh, idx)                         \
> +#define active_evtchns(sh, idx)                              \
>       ((sh)->evtchn_pending[idx] & ~(sh)->evtchn_mask[idx])
>  
>  int in_callback;
> @@ -69,7 +68,7 @@ void do_hypervisor_callback(struct __regs *regs)
>               l1i = ukarch_ffsl(l1);
>               l1 &= ~(1UL << l1i);
>  
> -             while ((l2 = active_evtchns(cpu, s, l1i)) != 0) {
> +             while ((l2 = active_evtchns(s, l1i)) != 0) {
>                       l2i = ukarch_ffsl(l2);
>                       l2 &= ~(1UL << l2i);
>  
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel