Re: [Minios-devel] [UNIKRAFT PATCH] driver/virtio: Host notify and ring desc debug msg

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 04.12.18, 15:10, "Sharan Santhanam" <Sharan.Santhanam@xxxxxxxxx> wrote:

    We provide additional debug message when notify the host of
    additional buffer and the descriptor information while enqueuing
    a buffer into the ring.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     plat/drivers/include/virtio/virtqueue.h | 4 +++-
     plat/drivers/virtio/virtio_ring.c       | 3 +++
     2 files changed, 6 insertions(+), 1 deletion(-)
    
    diff --git a/plat/drivers/include/virtio/virtqueue.h 
b/plat/drivers/include/virtio/virtqueue.h
    index 75efb2d..3d72c50 100644
    --- a/plat/drivers/include/virtio/virtqueue.h
    +++ b/plat/drivers/include/virtio/virtqueue.h
    @@ -228,8 +228,10 @@ static inline void virtqueue_host_notify(struct 
virtqueue *vq)
     {
        UK_ASSERT(vq);
     
    -   if (vq->vq_notify_host && virtqueue_notify_enabled(vq))
    +   if (vq->vq_notify_host && virtqueue_notify_enabled(vq)) {
    +           uk_pr_debug("notify queue %d\n", vq->queue_id);
                vq->vq_notify_host(vq->vdev, vq->queue_id);
    +   }
     }
     
     #ifdef __cplusplus
    diff --git a/plat/drivers/virtio/virtio_ring.c 
b/plat/drivers/virtio/virtio_ring.c
    index a1b0e03..02d568a 100644
    --- a/plat/drivers/virtio/virtio_ring.c
    +++ b/plat/drivers/virtio/virtio_ring.c
    @@ -326,6 +326,9 @@ int virtqueue_buffer_enqueue(struct virtqueue *vq, void 
*cookie,
        vrq->head_free_desc = idx;
        vrq->desc_avail -= total_desc;
     
    +   uk_pr_debug("Old head:%d, new head:%d, total_desc:%d\n",
    +               head_idx, idx, total_desc);
    +
        virtqueue_ring_update_avail(vrq, head_idx);
        return vrq->desc_avail;
     }
    -- 
    2.7.4
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel