Re: [Minios-devel] [UNIKRAFT PATCH] driver/virtio: memset virtio hdr regions

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 04.12.18, 15:25, "Sharan Santhanam" <Sharan.Santhanam@xxxxxxxxx> wrote:

    Explicitly memset the virtio header region with zero.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     plat/drivers/virtio/virtio_net.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/plat/drivers/virtio/virtio_net.c 
b/plat/drivers/virtio/virtio_net.c
    index 47a6161..75a6cd6 100644
    --- a/plat/drivers/virtio/virtio_net.c
    +++ b/plat/drivers/virtio/virtio_net.c
    @@ -341,7 +341,7 @@ static int virtio_netdev_xmit(struct uk_netdev *dev,
         * Fill the virtio-net-header with the necessary information.
         * Zero explicitly set.
         */
    -   vhdr->flags = 0;
    +   memset(vhdr, 0, sizeof(*vhdr));
        vhdr->gso_type = VIRTIO_NET_HDR_GSO_NONE;
     
        /**
    -- 
    2.7.4
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel