Re: [Minios-devel] [UNIKRAFT/LWIP PATCH 2/8] sys/socket.h: Include some libc header files first if available

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Florian,

Looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

============================================================
Dr. Felipe Huici
Chief Researcher, Systems and Machine Learning Group
NEC Laboratories Europe GmbH
Kurfuerstenanlage 36, D-69115 Heidelberg
Tel.  +49
(0)6221 4342-241
Fax:  +49
(0)6221 4342-155
 
e-mail:
felipe.huici@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

On 20.05.19, 13:30, "Minios-devel on behalf of Florian Schmidt" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
florian.schmidt@xxxxxxxxx> wrote:

    In that case, lwip won't try to be helpful and provide conflicting
    fallback definitions (which lead to a lot of compiler warnings).
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     include/sys/socket.h | 4 ++++
     1 file changed, 4 insertions(+)
    
    diff --git a/include/sys/socket.h b/include/sys/socket.h
    index 2a01877..90f80ba 100644
    --- a/include/sys/socket.h
    +++ b/include/sys/socket.h
    @@ -34,6 +34,10 @@
     #ifndef _UK_LWIP_SOCKET_H_
     
     #include <uk/config.h>
    +#if CONFIG_HAVE_LIBC
    +#include <fcntl.h>
    +#include <poll.h>
    +#endif
     #include <lwip/sockets.h>
     
     #ifndef SOCK_CLOEXEC
    -- 
    2.21.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel