Re: [Minios-devel] [UNIKRAFT/LWIP PATCH 6/8] Provide lwip socket function interfaces unconditionally

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Florian,

Looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

============================================================
Dr. Felipe Huici
Chief Researcher, Systems and Machine Learning Group
NEC Laboratories Europe GmbH
Kurfuerstenanlage 36, D-69115 Heidelberg
Tel.  +49
(0)6221 4342-241
Fax:  +49
(0)6221 4342-155
 
e-mail:
felipe.huici@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

On 20.05.19, 13:30, "Minios-devel on behalf of Florian Schmidt" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
florian.schmidt@xxxxxxxxx> wrote:

    Considering newlib, as compiled for unikraft, does not provide a socket
    API, these should always be provided, not only when nolibc is used.
    
    Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    ---
     include/sys/socket.h | 2 --
     1 file changed, 2 deletions(-)
    
    diff --git a/include/sys/socket.h b/include/sys/socket.h
    index 11f622d..53d9301 100644
    --- a/include/sys/socket.h
    +++ b/include/sys/socket.h
    @@ -50,7 +50,6 @@
     
     #define ioctl(s, cmd, argp) lwip_ioctl(s, cmd, argp)
     
    -#ifdef CONFIG_LIBNOLIBC
     int socket(int domain, int type, int protocol);
     int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
     int bind(int s, const struct sockaddr *name, socklen_t namelen);
    @@ -69,6 +68,5 @@ int send(int s, const void *dataptr, size_t size, int 
flags);
     int sendmsg(int s, const struct msghdr *message, int flags);
     int sendto(int s, const void *dataptr, size_t size, int flags,
           const struct sockaddr *to, socklen_t tolen);
    -#endif /* CONFIG_LIBNOLIBC */
     
     #endif /* _UK_LWIP_SOCKET_H_ */
    -- 
    2.21.0
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel