Re: [Minios-devel] [UNIKRAFT/LWIP PATCH 1/8] Move export.syms to exportsyms.uk

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Florian,

It's fine to leave as is, it also follows the pattern we're using for other 
libs, where we expose functionality as needed.

Thanks,

-- Felipe

On 27.05.19, 14:09, "Florian Schmidt" <Florian.Schmidt@xxxxxxxxx> wrote:

    Hi Felipe,
    
    this is really a thing that has its pros and cons. I basically went with 
    the basic set that a C program might need, using the standard bunch of 
    socket functions (lwip_* functions are exported because lwip provides 
    preprocessor macros for them from `foo` to `lwip_foo`). If you have 
    found more functions that you think should be added, I'm happy to add 
    those, or, alternatively add them in a patch on top of this series later on.
    
    On 5/27/19 1:49 PM, Felipe Huici wrote:
    > Hi Florian,
    > 
    > This certainly does not expose enough functionality to compile against 
anything but the simplest c socket program. Still, I guess it makes more sense 
to leave this minimal set, and have additional libraries expose further 
functions as needed.
    > 
    > Thanks,
    > 
    > -- Felipe
    > 
    > Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>
    > 
    > On 20.05.19, 13:30, "Minios-devel on behalf of Florian Schmidt" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
florian.schmidt@xxxxxxxxx> wrote:
    > 
    >      This file was ignored up to now because it followed a superseded 
naming
    >      standard. This patch also adds lwip_htonl, lwip_htons, and 
lwip_select
    >      to exportsyms.uk, because those are known to be used by applications,
    >      and provided via #defines of their non-prefixed versions.
    >      
    >      Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
    >      ---
    >       export.syms => exportsyms.uk | 15 +++++++++------
    >       1 file changed, 9 insertions(+), 6 deletions(-)
    >       rename export.syms => exportsyms.uk (80%)
    >      
    >      diff --git a/export.syms b/exportsyms.uk
    >      similarity index 80%
    >      rename from export.syms
    >      rename to exportsyms.uk
    >      index ec7c2bf..42e255f 100644
    >      --- a/export.syms
    >      +++ b/exportsyms.uk
    >      @@ -1,17 +1,20 @@
    >      -liblwip_init
    >      -socket
    >       accept
    >       bind
    >      -shutdown
    >      +connect
    >       getpeername
    >       getsockname
    >       getsockopt
    >      -setsockopt
    >      -connect
    >      +liblwip_init
    >       listen
    >      +lwip_htonl
    >      +lwip_htons
    >      +lwip_select
    >       recv
    >       recvfrom
    >      +select
    >       send
    >       sendmsg
    >       sendto
    >      -select
    >      +setsockopt
    >      +shutdown
    >      +socket
    >      --
    >      2.21.0
    >      
    >      
    >      _______________________________________________
    >      Minios-devel mailing list
    >      Minios-devel@xxxxxxxxxxxxxxxxxxxx
    >      https://lists.xenproject.org/mailman/listinfo/minios-devel
    > 
    
    -- 
    Dr. Florian Schmidt
    フローリアン・シュミット
    Research Scientist,
    Systems and Machine Learning Group
    NEC Laboratories Europe
    Kurfürsten-Anlage 36, D-69115 Heidelberg
    Tel.     +49 (0)6221 4342-265
    Fax:     +49 (0)6221 4342-155
    e-mail:  florian.schmidt@xxxxxxxxx
    ============================================================
    Registered at Amtsgericht Mannheim, Germany, HRB728558
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel