[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH 4/8] lib/ukdebug: key-value static storage for tracing



Costin Lupu <costin.lup@xxxxxxxxx> writes:

> On 5/29/19 3:17 PM, Yuri Volchkov wrote:
>> Hi,
>> 
>> Costin Lupu <costin.lup@xxxxxxxxx> writes:
>> 
>>> And another thing I forgot, please see inline.
>>>
>>> On 5/29/19 8:27 AM, Costin Lupu wrote:
>>>> Hi Yuri,
>>>>
>>>> It's not obvious why we need this key-value thing. Can you please extend
>>>> the commit message or the comment or both with some use cases where this
>>>> would be useful?
>> 
>> This is well described in the comment in the code itself. I don't see a
>> point to write the same words in the commit message. And use-case is
>> given too - tracing buffer format version number.
>> 
>
> You mean that's the *only* use case?
For now it is the only case. Potentially more key-values will be needed
as the functionality grows


-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.