Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukunistd: Move utsname.h to uksysinfo library

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, this patch looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 02.06.19, 13:49, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    Commit bbcb60ce wrongfully moved this header to ukunistd library instead of
    uksysinfo, where uname() implementation is placed.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     lib/uksysinfo/Makefile.uk                         | 3 +++
     lib/{ukunistd => uksysinfo}/include/sys/utsname.h | 0
     lib/ukunistd/Makefile.uk                          | 3 ---
     3 files changed, 3 insertions(+), 3 deletions(-)
     rename lib/{ukunistd => uksysinfo}/include/sys/utsname.h (100%)
    
    diff --git a/lib/uksysinfo/Makefile.uk b/lib/uksysinfo/Makefile.uk
    index 707c69f4..28e99fb5 100644
    --- a/lib/uksysinfo/Makefile.uk
    +++ b/lib/uksysinfo/Makefile.uk
    @@ -1,3 +1,6 @@
     $(eval $(call addlib_s,uksysinfo,$(CONFIG_UKSYSINFO)))
     
    +CINCLUDES-$(CONFIG_UKSYSINFO)    += -I$(UKSYSINFO_BASE)/include
    +CXXINCLUDES-$(CONFIG_UKSYSINFO)  += -I$(UKSYSINFO_BASE)/include
    +
     UKSYSINFO_SRCS-$(CONFIG_UKSYSINFO) += $(UKSYSINFO_BASE)/sysinfo.c
    diff --git a/lib/ukunistd/include/sys/utsname.h 
b/lib/uksysinfo/include/sys/utsname.h
    similarity index 100%
    rename from lib/ukunistd/include/sys/utsname.h
    rename to lib/uksysinfo/include/sys/utsname.h
    diff --git a/lib/ukunistd/Makefile.uk b/lib/ukunistd/Makefile.uk
    index 0ad9c56a..3c7a8229 100644
    --- a/lib/ukunistd/Makefile.uk
    +++ b/lib/ukunistd/Makefile.uk
    @@ -1,6 +1,3 @@
     $(eval $(call addlib_s,ukunistd,$(CONFIG_UKUNISTD)))
     
    -CINCLUDES-$(CONFIG_UKUNISTD)    += -I$(UKUNISTD_BASE)/include
    -CXXINCLUDES-$(CONFIG_UKUNISTD)  += -I$(UKUNISTD_BASE)/include
    -
     UKUNISTD_SRCS-$(CONFIG_UKUNISTD) += $(UKUNISTD_BASE)/user.c
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel