Re: [Minios-devel] [UNIKRAFT/LIBCXX PATCH] Add features.h

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, 

I hesitated here between leaving the patch as is or asking that you put compile 
guards arond #include <sys/features.h>, since this is newlib-specific. I guess 
if we leave it as is it'll act as a reminder to people porting other libcs to 
touch this file, rather than silently fail, so better leave it as is.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 01.06.19, 22:17, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    When threads are enabled, cxx library includes a 'features.h' header in its
    'include/__config' header from origin. The header introduced by this patch
    includes the 'sys/features.h' header from newlib.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     include/features.h | 43 +++++++++++++++++++++++++++++++++++++++++++
     1 file changed, 43 insertions(+)
     create mode 100644 include/features.h
    
    diff --git a/include/features.h b/include/features.h
    new file mode 100644
    index 0000000..feb01db
    --- /dev/null
    +++ b/include/features.h
    @@ -0,0 +1,43 @@
    +/* SPDX-License-Identifier: BSD-3-Clause */
    +/*
    + * Copyright (c) 2019, University Politehnica of Bucharest
    + * All rights reserved.
    + *
    + * Redistribution and use in source and binary forms, with or without
    + * modification, are permitted provided that the following conditions
    + * are met:
    + * 1. Redistributions of source code must retain the above copyright
    + *    notice, this list of conditions and the following disclaimer.
    + * 2. Redistributions in binary form must reproduce the above copyright
    + *    notice, this list of conditions and the following disclaimer in the
    + *    documentation and/or other materials provided with the distribution.
    + * 3. Neither the name of the author nor the names of any co-contributors
    + *    may be used to endorse or promote products derived from this software
    + *    without specific prior written permission.
    + *
    + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
    + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
    + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
    + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
    + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
    + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
    + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 
STRICT
    + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY 
WAY
    + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
    + * SUCH DAMAGE.
    + */
    +#ifndef __LIBUNWIND__FEATURES_H__
    +#define __LIBUNWIND__FEATURES_H__
    +
    +#ifdef __cplusplus
    +extern "C" {
    +#endif
    +
    +#include <sys/features.h>
    +
    +#ifdef __cplusplus
    +}
    +#endif
    +#endif /* __LIBUNWIND__FEATURES_H__ */
    +
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel