Re: [Minios-devel] [UNIKRAFT early RFC PATCH 04/11] plat/kvm/smp: Add smp definitions in smp.h

[Julien Grall <julien.grall@xxxxxxx>]

On 21/06/2019 07:57, Jia He wrote:
> Add smp definitions in smp.h
IHMO, function prototype should be defined in the same place as the 
implementation. Otherwise, this makes quite difficult to review and check 
everything is ok.
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/common/include/smp.h | 42 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
>   create mode 100644 plat/common/include/smp.h
>
> diff --git a/plat/common/include/smp.h b/plat/common/include/smp.h
> new file mode 100644
> index 0000000..38f801d
> --- /dev/null
> +++ b/plat/common/include/smp.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/*
> + * Authors: Jia He <justin.he@xxxxxxx>
> + *
> + * Copyright (c) 2019, Arm Ltd. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of the copyright holder nor the names of its
> + *    contributors may be used to endorse or promote products derived from
> + *    this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> + */
> +#ifndef __PLAT_CMN_SMP_H__
> +#define __PLAT_CMN_SMP_H__
> +
> +#define        MAXCPU          8 /* hard limitation for CPU number */
> +extern int cpu_possible_map[MAXCPU];
> +
> +void release_aps(void);
> +int start_cpu(uint64_t target_cpu);
> +#endif /* __PLAT_CMN_SMP_H__ */
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel