Re: [Minios-devel] [UNIKRAFT early RFC PATCH 05/11] plat/kvm/smp: Add psci call psci_cpu_on

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 21/06/2019 07:57, Jia He wrote:
> Add psci call psci_cpu_on
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/kvm/arm/setup.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/plat/kvm/arm/setup.c b/plat/kvm/arm/setup.c
> index 6125a30..1f6e458 100644
> --- a/plat/kvm/arm/setup.c
> +++ b/plat/kvm/arm/setup.c
> @@ -41,6 +41,12 @@ smcc_psci_callfn_t smcc_psci_call;
>   extern void _libkvmplat_newstack(uint64_t stack_start,
>                         void (*tramp)(void *), void *arg);
>   
> +int psci_cpu_on(unsigned long cpu, unsigned long entry)
PSCI is nothing KVM specific, can this be moved in a common file?

> +{
> +       /* PSCI v0.1 and v0.2 both support cpu_on. */
The code in _dtb_get_psci_method() says that 0.1 is not supported.

> +       return smcc_psci_hvc_call(PSCI_FNID_CPU_ON, cpu, entry, cpu);
I think you want to call smcc_psci_call(...) here so you support both SMC and 
HVC seamlessly.
> +}
> +
>   static void _init_dtb(void *dtb_pointer)
>   {
>         int ret;
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel