Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Modify ctor iteration to end at uk_ctortab_end

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Vlad,

I am actually wondering why we have still have two ctors.h files. With 
your changes to the table - which I really like - the preinit, init, and 
unikraft constructor table look and work exactly the same, so I would 
prefer that we better merge the headers.
The least intrusive option to the current code base would be to move the 
content from <uk/plat/ctors.h> into <uk/ctors.h>, adapt the naming 
(ukplat_ctor_* to uk_ctor_*), and adopt boot.c.
We have then a single place and you could even re-use the foreach macro 
to iterate over the constructors.
What do you think?

Thanks,

Simon

On 27.08.19 19:28, Vlad-Andrei BĂDOIU (78692) wrote:
> This patch adds a new variable uk_ctortab_end that points to the ends of
> the ctortab section. Until now we would have a LONG(0) at the end of the
> ctortab section which has 32 bits. We could use QUAD(0) or LONG(0)
> depending on the arch but adding a variable check makes the script arch
> independent.
>
> Vlad-Andrei Badoiu (3):
>    plat/common: Add uk_ctortab_end in the linker script
>    lib/ukboot: Modify ctor iteration to end at uk_ctortab_end
>    plat/*: Move ctortab before rodata on all platforms
>
>   include/uk/ctors.h               | 1 +
>   lib/ukboot/boot.c                | 2 +-
>   plat/common/include/common.lds.h | 4 ++--
>   plat/kvm/arm/link64.lds.S        | 5 +++--
>   plat/linuxu/arm/link.lds.S       | 2 +-
>   plat/linuxu/x86/link64.lds.S     | 2 +-
>   plat/xen/arm/link32.lds.S        | 4 ++--
>   7 files changed, 11 insertions(+), 9 deletions(-)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel