Re: [Minios-devel] [UNIKRAFT PATCH 1/3] plat/common: Add uk_ctortab_end in the linker script

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Looks good. Thanks.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 27.08.19 19:28, Vlad-Andrei BĂDOIU (78692) wrote:
> Currently we use LONG(0) in the linker script and a NULL chec to find the end of
> the ctortab section. This approach does not work on different arhitectures
> because LONG(0) has only 32 bits. To make the script arch independent, we add a
> new variable uk_ctortab_end at the end of the ctortab section.
>
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> ---
>   plat/common/include/common.lds.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plat/common/include/common.lds.h b/plat/common/include/common.lds.h
> index 5ccaadb3..b06dd962 100644
> --- a/plat/common/include/common.lds.h
> +++ b/plat/common/include/common.lds.h
> @@ -91,8 +91,8 @@
>         .uk_ctortab :                                                   \
>         {                                                               \
>                 KEEP(*(SORT_BY_NAME(.uk_ctortab[0-7])))                 \
> -               LONG(0)                                                 \
> -       }
> +       }                                                               \
> +       uk_ctortab_end = .;
>   
>   #define TLS_SECTIONS							\
>         . = ALIGN(0x8);                                                 \
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel