[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Configure IO C99 formats and errno extensions


  • To: Costin Lupu <costin.lupu@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
  • From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
  • Date: Mon, 16 Sep 2019 12:01:46 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sm0QuaGeVQ4XAGDcV6mnDgZgpfNSC9PT68CfpzGV0KM=; b=FpV/dYgOaWhpghiPpoVjh8ULAzGncQ+k+kkWXGCGFouf6Cl3Z7ixMzkiXSB/4XYnM/78URN2cqonfkKDtizB/VvxF2H6oZibUgtJ/z77J7K89tB1h7nZE7vBAF6049s3iL/TdirmuQyMRiw2e/FjxAHSr3/U9yIKYq8lvIcrNQWKgCuv1agqR/qmcKK4UCJPeyo5l02XAU63MnPyGoqTuPbac6uaxNY2yXTyr/X0ws6HTGrWqszpQTCm5X/DBa6wKQ3wend9vPf4478rlR8yBx2wUCI1M5W4EsoEexuAySR4TxCC5aX2aTVmaeSWv4ZxnkELtdYANiFLeo5VkpkMGQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PaXBl39Sinbg1xgJUu/lXbs2ep/kkfZpW8EicsFyhVR36xEjLfrR4Jqj6FEWq6nFranoWOpuUmiMnoqyQyUnulggsXQW5dG4XTHZ9KrJ3OAR9gryZ4+/tf7D/HvysYZNL+1+OnGPP7BldWq6QX+6iUu7WsIDbjt7khmE0kvvKEFxkroNG8XVt6Hu4GaKJPqcmPvFeFTSKpcpp+wvKW5VWuuw/I8ue2yXo3J/HF1cBOpUMmj97DTN7s7zoJD3oZQIchZa4mj5AIxzzLqQqf1coTi/v9PwS8KPfs6MG8oxP6xWF9LH4ZgO3LgmJtIuRHb3YCpzQ0l6bPW8mGTA6QkKNA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
  • Cc: "felipe.huici@xxxxxxxxx" <felipe.huici@xxxxxxxxx>
  • Delivery-date: Mon, 16 Sep 2019 12:01:53 +0000
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: AQHVaUUmMRFwXfnWBEiGXR4jVALtRqcuOnqA
  • Thread-topic: [UNIKRAFT/NEWLIB PATCH] Configure IO C99 formats and errno extensions

Hi Costin,

This patch looks good. Thanks!

Vlad

Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>

On 12.09.2019 11:36, Costin Lupu wrote:
> This patch adds support for enabling the following extensions:
> * IO C99 formats enable more options for formatting output. We need this to
> support "%z" in Python 3
> * Linux errno extensions define more error numbers. We need this to support
> ESHUTDOWN in Python 3
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Config.uk   | 10 ++++++++++
>   Makefile.uk |  2 ++
>   2 files changed, 12 insertions(+)
>
> diff --git a/Config.uk b/Config.uk
> index 89010a1..da587ba 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -10,3 +10,13 @@ menuconfig LIBNEWLIBC
>       select LIBNEWLIBM if LIBNEWLIBC
>       select LIBUKALLOC
>       select LIBVFSCORE
> +
> +if LIBNEWLIBC
> +     config LIBNEWLIBC_WANT_IO_C99_FORMATS
> +             bool "Use C99 IO formats"
> +             default n
> +
> +     config LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS
> +             bool "Use Linux errno extensions"
> +             default n
> +endif
> diff --git a/Makefile.uk b/Makefile.uk
> index 01da724..812f602 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -82,6 +82,8 @@ LIBNEWLIBM_CXXINCLUDES += -I$(LIBNEWLIB_LIBM)/common
>   
> ################################################################################
>   LIBNEWLIB_GLOBAL_FLAGS-y  += -DMISSING_SYSCALL_NAMES -DMALLOC_PROVIDED
>   LIBNEWLIB_GLOBAL_FLAGS-y  += -D_POSIX_REALTIME_SIGNALS
> +LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_WANT_IO_C99_FORMATS) += 
> -D_WANT_IO_C99_FORMATS
> +LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS) += 
> -D__LINUX_ERRNO_EXTENSIONS__
>   
>   CFLAGS-y   += $(LIBNEWLIB_GLOBAL_FLAGS-y)
>   CXXFLAGS-y += $(LIBNEWLIB_GLOBAL_FLAGS-y)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.