Re: [Minios-devel] [UNIKRAFT/LWIP PATCH 1/2] sockets.c: Set stub for .vop_getattr operation

[Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>]

Hi Costin,

Thanks!

Vlad

Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>

On 12.09.2019 12:00, Costin Lupu wrote:
> We currently just set a stub for .vop_getattr operation in order to avoid
> crashes. And since we are here, this patch also disables the 
> cast-function-type
> warnings which annoyingly apear for each source file that sets some filesystem
> callbacks.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Makefile.uk | 1 +
>   sockets.c   | 2 ++
>   2 files changed, 3 insertions(+)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 2292cb4..0e72336 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -85,6 +85,7 @@ LIBLWIP_SRCS-$(CONFIG_LWIP_THREADS) += 
> $(LIBLWIP_BASE)/threads.c|unikraft
>   LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/init.c|unikraft
>   LIBLWIP_SRCS-y += $(LIBLWIP_BASE)/time.c|unikraft
>   LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/sockets.c|unikraft
> +LIBLWIP_SOCKETS_FLAGS-y += -Wno-cast-function-type
>   LIBLWIP_SRCS-$(CONFIG_LWIP_SOCKET) += $(LIBLWIP_BASE)/getnameinfo.c|unikraft
>   LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/init.c
>   LIBLWIP_SRCS-y += $(LIBLWIP_EXTRACTED)/core/def.c
> diff --git a/sockets.c b/sockets.c
> index f4f7d40..cd84b97 100644
> --- a/sockets.c
> +++ b/sockets.c
> @@ -62,6 +62,7 @@ static int sock_net_ioctl(struct vnode *s_vnode,
>                       unsigned long request,
>                       void *buf);
>   
> +#define sock_net_getattr   ((vnop_getattr_t) vfscore_vop_einval)
>   #define sock_net_inactive  ((vnop_inactive_t) vfscore_vop_nullop)
>   
>   static struct vnops sock_net_vnops = {
> @@ -69,6 +70,7 @@ static struct vnops sock_net_vnops = {
>       .vop_write = sock_net_write,
>       .vop_read  = sock_net_read,
>       .vop_ioctl = sock_net_ioctl,
> +     .vop_getattr = sock_net_getattr,
>       .vop_inactive = sock_net_inactive
>   };
>   
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel