Re: [Minios-devel] [UNIKRAFT PATCH] lib/uknetdev: Select virtio driver on KVM when enabling library

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

On 09.10.19 11:47, Costin Lupu wrote:
> On 10/9/19 12:39 PM, Simon Kuenzer wrote:
> > Hey,
> >
> > I agree that the current state with selecting the network driver
> > explicitly is not nice and fixing this makes totally sense. However,
> > can't we solve this change the opposite way round, from within the KVM
> > platform?:
> >
> > ```
> > config VIRTIO_NET
> >         bool "Virtio Net device"
> >         default y if LIBUKNETDEV
> >         default n
> >         depends on LIBUKNETDEV
> >         select VIRTIO_BUS
> >         select LIBUKSGLIST
> >         help
> >                Virtual network driver.
> > ```
> >
> > I am concerned that putting platform library details into the general
> > purpose libraries is bound to get inconsistent/incomplete. For instance,
> > how would you handle this with external platforms?
> If you look at it from a higher perspective, for your app you would only
> want network connectivity and you would just tick a "Network enabled"
> option or, how we do it now, tick the lwip support. Everything else gets
> enabled.
>
> The majority of users/developers/configurators won't care (at least at
> the beginning) which driver is selected or whether they want to
> customize/change the driver.
>
> Again, this issue and its solution came up after our previous
> experiences with the Unikraft hackathons.
I did not disagree. This was not my point. My suggested option:
 default y if LIBUKNETDEV
in the KVM platform is exactly achieving what you want. But it also 
gives the option to still de-select it and we do not bloat the Config.uk 
of libuknetdev with platform driver details.
> Cheers,
> Costin
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel