Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 5/5] Fix some other missing header inclusions

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, this looks ok.  

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 13.10.19, 15:37, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    It is worth saying here that we previously forgot to add the declarations 
for
    wait3() and wait4() stubs.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     include/sys/uio.h  | 2 ++
     include/sys/wait.h | 4 ++++
     resource.c         | 1 +
     3 files changed, 7 insertions(+)
    
    diff --git a/include/sys/uio.h b/include/sys/uio.h
    index 3c821be..2386256 100644
    --- a/include/sys/uio.h
    +++ b/include/sys/uio.h
    @@ -40,6 +40,8 @@
     extern "C" {
     #endif
     
    +#include <sys/types.h>
    +
     #define UIO_MAXIOV 1024
     
     struct iovec {
    diff --git a/include/sys/wait.h b/include/sys/wait.h
    index 8118996..b6b48d0 100644
    --- a/include/sys/wait.h
    +++ b/include/sys/wait.h
    @@ -36,8 +36,12 @@
     #define __NEWLIB_GLUE__SYS_WAIT_H__
     
     #include_next <sys/wait.h>
    +#include <sys/resource.h>
     
     #define WCOREDUMP(w)       (((w) & 0xff) == 0x80)
     #define WIFCONTINUED(w)    (WIFSIGNALED(w) && WEXITSTATUS(w) == 18)
     
    +pid_t wait3(int *wstatus, int options, struct rusage *rusage);
    +pid_t wait4(pid_t pid, int *wstatus, int options, struct rusage *rusage);
    +
     #endif
    diff --git a/resource.c b/resource.c
    index 30d0028..fe61ef3 100644
    --- a/resource.c
    +++ b/resource.c
    @@ -36,6 +36,7 @@
      */
     
     #include <sys/resource.h>
    +#include <uk/essentials.h>
     
     int getrlimit(int resource __unused, struct rlimit *rlim __unused)
     {
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel