Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 1/2] Makefile.uk: Use _HAVE_LONG_DOUBLE as global preprocessing symbol

[Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>]

Reviewed-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>

On Sun, Nov 17, 2019 at 12:06 AM Costin Lupu <costin.lup@xxxxxxxxx> wrote:
>
> Given that it is used in <stdlib.h> header, _HAVE_LONG_DOUBLE needs to be
> globally visible and not just internally, only for newlib code.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>  Makefile.uk | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 5254956..9eb1f03 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -86,6 +86,7 @@ 
> LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_WANT_IO_C99_FORMATS) += 
> -D_WANT_IO_C9
>  LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS) += 
> -D__LINUX_ERRNO_EXTENSIONS__
>  ifeq ($(CONFIG_ARCH_X86_64),y)
>  LIBNEWLIB_GLOBAL_FLAGS-y  += -D_LDBL_EQ_DBL
> +LIBNEWLIB_GLOBAL_FLAGS-y  += -D_HAVE_LONG_DOUBLE
>  endif
>
>  CFLAGS-y   += $(LIBNEWLIB_GLOBAL_FLAGS-y)
> @@ -627,12 +628,11 @@ LIBNEWLIBC_SRCS-y += 
> $(LIBNEWLIB_LIBC)/stdlib/reallocarray.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/reallocf.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/sb_charsets.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtod.c
> -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtodg.c|longdouble
> -LIBNEWLIBC_STRTODG_LONGDOUBLE_FLAGS-y += -D_HAVE_LONG_DOUBLE
> +LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtodg.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtoimax.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtol.c
> -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtorx.c|longdouble
> -LIBNEWLIBC_STRTORX_LONGDOUBLE_FLAGS-y += -D_HAVE_LONG_DOUBLE
> +LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtold.c
> +LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtorx.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtoul.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtoumax.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/utoa.c
> @@ -693,8 +693,6 @@ LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/wcrtomb.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/wcsnrtombs.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/wcsrtombs.c
>  LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/wctob.c
> -LIBNEWLIBC_SRCS-y += $(LIBNEWLIB_LIBC)/stdlib/strtold.c|longdouble
> -LIBNEWLIBC_STRTOLD_LONGDOUBLE_FLAGS-y += -D_HAVE_LONG_DOUBLE
>
>  
> ################################################################################
>  # Newlib/libc code -- string
> --
> 2.20.1
>

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel