Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 2/2] sys/poll.h: Declare poll() even if CONFIG_LWIP_SOCKET is defined

[Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>]

Reviewed-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>

On Sun, Nov 17, 2019 at 12:06 AM Costin Lupu <costin.lup@xxxxxxxxx> wrote:
>
> We need the poll() declaration even when CONFIG_LWIP_SOCKET is defined. We
> disable only the macros values if CONFIG_LWIP_SOCKET is defined because lwip
> comes with its own values.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>  include/sys/poll.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/sys/poll.h b/include/sys/poll.h
> index 0485658..0827738 100644
> --- a/include/sys/poll.h
> +++ b/include/sys/poll.h
> @@ -80,7 +80,8 @@ struct pollfd {
>  #define POLLHUP     0x010   /* file descriptor was "hung up" */
>  #define POLLNVAL    0x020   /* requested events "invalid" */
>
> +#endif /* !CONFIG_LWIP_SOCKET */
> +
>  int poll(struct pollfd _pfd[], nfds_t _nfds, int _timeout);
>
> -#endif /* !CONFIG_LWIP_SOCKET */
>  #endif /* _POSIX_SYS_POLL_H_ */
> --
> 2.20.1
>

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel