Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Introduce posix-crypt internal library

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Costin,

thanks a lot for your work. Could you also add a message why providing 
`crypt` and `crypt_r` with the Unikraft base repo is needed? E.g., are 
there any common and shared modifications needed for supporting libc 
implementations or is there an internal direct dependency? If not, I 
prefer to avoid introducing us maintainance effort for copies of code 
that is usually provided with a libc. In the latter case I suggest to 
introduce posix-crypt as external library.
Thanks,

Simon

On 25.11.19 23:37, Costin Lupu wrote:
> This is needed for providing crypt() and crypt_r() functions.
>
> Costin Lupu (3):
>    lib/posix-crypt: Introduce library skeleton
>    lib/posix-crypt: Import code from musl
>    lib/posix-crypt: Adapt imported musl code to Unikraft
>
>   lib/Makefile.uk                               |    1 +
>   lib/posix-crypt/Config.uk                     |    3 +
>   lib/posix-crypt/Makefile.uk                   |   20 +
>   lib/posix-crypt/musl-imported/include/crypt.h |   20 +
>   .../musl-imported/src/crypt/crypt.c           |   14 +
>   .../musl-imported/src/crypt/crypt_blowfish.c  |  798 +++++++++++++
>   .../musl-imported/src/crypt/crypt_des.c       | 1016 +++++++++++++++++
>   .../musl-imported/src/crypt/crypt_des.h       |   14 +
>   .../musl-imported/src/crypt/crypt_md5.c       |  285 +++++
>   .../musl-imported/src/crypt/crypt_r.c         |   23 +
>   .../musl-imported/src/crypt/crypt_sha256.c    |  322 ++++++
>   .../musl-imported/src/crypt/crypt_sha512.c    |  371 ++++++
>   .../musl-imported/src/crypt/encrypt.c         |   52 +
>   .../musl-imported/src/include/crypt.h         |   16 +
>   14 files changed, 2955 insertions(+)
>   create mode 100644 lib/posix-crypt/Config.uk
>   create mode 100644 lib/posix-crypt/Makefile.uk
>   create mode 100644 lib/posix-crypt/musl-imported/include/crypt.h
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_blowfish.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_des.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_des.h
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_md5.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_r.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_sha256.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/crypt_sha512.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/crypt/encrypt.c
>   create mode 100644 lib/posix-crypt/musl-imported/src/include/crypt.h
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel