Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Introduce posix-crypt internal library

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 11/27/19 10:43 AM, Simon Kuenzer wrote:
> Hey Costin,
> 
> thanks a lot for your work. Could you also add a message why providing
> `crypt` and `crypt_r` with the Unikraft base repo is needed? E.g., are
> there any common and shared modifications needed for supporting libc
> implementations or is there an internal direct dependency? If not, I
> prefer to avoid introducing us maintainance effort for copies of code
> that is usually provided with a libc. In the latter case I suggest to
> introduce posix-crypt as external library.

Hi Simon,

We need crypt/crypt_r with newlib which doesn't implement them. The
alternative would have been to put the code into newlib's glue code. But
then, what happens with other libc implementation which doesn't provide
crypt? We would have to copy it there as well, right?

With this approach I think the maintenance effort is reduced when adding
it into Unikraft. And I think it's even less effort compared with making
it external, which would have to be cloned separately. Btw, would crypt
have original code?

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel