Re: [Minios-devel] [UNIKRAFT/LIBNEWLIB PATCH] Config.uk: remove imply of shim layer library

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks a lot.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

> On 12. Mar 2020, at 15:39, Felipe Huici <Felipe.Huici@xxxxxxxxx> wrote:
> 
> Currently, Config.uk sets imply LIBSYSCALL_SHIM, which for all intents
> and purposes forces all images built with newlib to include the
> syscall shim even when it's not needed. While "imply" still allows
> users to manually deselect the option, one has to know about this
> possiblity, and kraft-driven builds will not do this by default.
> 
> For applications that *do* need the shim library, this should be set
> explicitly in their Config.uk files, or in their respective kraft.yaml
> file.
> 
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
> Config.uk | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/Config.uk b/Config.uk
> index 8cb1058..ab127f0 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -13,7 +13,6 @@ menuconfig LIBNEWLIBC
>       select LIBVFSCORE
>       select LIBPOSIX_PROCESS
>       select LIBPOSIX_USER
> -     imply LIBSYSCALL_SHIM
> 
> if LIBNEWLIBC
>       config LIBNEWLIBC_WANT_IO_C99_FORMATS
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel