[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v3 3/8] build: Test parameter P= containing absolute paths only



Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Fri, Mar 27, 2020 at 4:36 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Stops building with an error message when P= (platform libraries)
> contains at least on library that is not given with its absolute
> path. The build system does not support relative paths.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 13fed332..d832f737 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -138,6 +138,7 @@ override O := $(BUILD_DIR)
>  # Retrieved from P variable from the command line (paths separated by colon)
>  ifeq ("$(origin P)", "command line")
>  $(foreach E,$(subst :, ,$(P)), \
> +$(if $(filter /%,$(E)),,$(error Path to external platform "$(E)" (P) is not 
> absolute));\
>  $(if $(wildcard $(E)), \
>         $(eval EPLAT_DIR += $(E)) \
>  , $(if $(wildcard $(CONFIG_UK_BASE)/$(E)),\
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.