[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v3 4/8] build: Test parameter L= containing absolute paths only



Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Fri, Mar 27, 2020 at 4:36 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Stops building with an error message when L= (external libraries)
> contains at least on library that is not given with its absolute
> path. The build system does not support relative paths.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index d832f737..9e5f6414 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -161,6 +161,7 @@ endif
>  ifeq ("$(origin L)", "command line")
>  # library path exists?
>  $(foreach E,$(subst :, ,$(L)), \
> +$(if $(filter /%,$(E)),,$(error Path to external library "$(E)" (L) is not 
> absolute));\
>  $(if $(wildcard $(E)), \
>         $(eval ELIB_DIR += $(E)) \
>  , $(if $(wildcard $(CONFIG_UK_BASE)/$(E)),\
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.